Developer Policies - Proxima-Project/Proxi-Bay12 GitHub Wiki

The Big Two

  • Developers shall not approve or merge their own pull requests.*
    • Updates to the credits (header.html), changelog and Code of Conduct may be merged by the author after 24 hours have elapsed since an approving review by another developer.
  • Developers shall not merge a pull request that they alone have approved until 24 hours have elapsed since the approving review.*

*These rules may be overruled in specific cases, such as a critical bug fix.

The Rest

  • After conference with the team, any Developer may mark any pull request Last Chance, and then close the marked pull request after the stipulated time (usually 3-5 days) if no Developer steps forward to support it.
  • Provided the author is notified at the time of marking, Developers may close any pull request correctly marked Awaiting Author or Merge Conflicts after 10 days of author inactivity.
    • Any Developer can re-open these pull requests once the author has time to attend to them.