refactoring week - Poobslag/turbofat GitHub Wiki

Refactoring week occurs every two months. It's good for code to have time to rest, where we can clean up technical debt.

Refactoring backlog

  • chat-narrator.chat has an unusual structure, referencing #narrator# in the chat lines. Is this valid?
  • There's no consistency with credits stuff being mixed in with normal stuff, being placed in the 'lava' directory or the 'credits' directory. We should try to make this more consistent.
  • Move free-roam-sensei.gd, free-roam-player.gd, other free roam logic out of /src/main. This stuff is only used in the free roam demos, it does not belong in our released game code.
  • When running the exported Windows build, we see a 'Resources still in use at exit' error. Apparently this is related to poof-sprite.gd, or perhaps string-utils.gd, or it could just be a bug where scripts aren't unloaded. We should explore it.
  • Demos don't need to say Demo which shows off foo, they can just start with Shows off foo
  • Reuse DiagonalParticles.tscn in more places, such as the Puzzle or CareerUi scenes.
  • credits-director.gd for loops are unnecessarily using for i in... when they could just use for credit in... because they never need the numeric value
  • Reorder graphics-settings json dict; maybe other settings too. Probably alphabetical.
  • Use ui_click in more places that use mouse handling code.
  • Steam linux files should just be turbofat.pck, not turbofat-linux.pck