Week 8: Collaborate & Testing shared prototype - Plous01/ProjectTech GitHub Wiki
Why we chose this repository
There a some reasons why we chose to work on this repository:
- To learn Pug. I made my project with the template engine 'Pug'. My team members worked with EJS, but they wanted to learn more about Pug.
- Amor already had some basic functionalities that actually worked, so we wanted to build on top of that.
- I used ES6 with arrow functions, so the code was more consistent.
- A good starting point to add some new features.
- Job stories of all the team members could be easily modified.
Main goals
- Work on the basic functionalities and ensure it works good.
- Add new features based on the results of the usability test.
- Learn how to deploy.
- Learn how to work on the same project on Github.
- Create consistent code, learn how to code.
Rules within the team
- You need at least two reviews on your pull request before you can merge something.
- We use ES Linter (one of the most popular linters), to make sure that our code validates.
- Commit regularly
- Be on time
Points of improvement
- A better devision of labor
- Be more critical about each others code
- Give more feedback
- Communicate better and ask more questions
- Help each other
- More commits
- Beautify code and use more efficient code (use more files)
- Not every feature works perfectly (for example, the upload photo, where did the photo go?)
End goals:
- Cleaner code
- Better styling
- More research about the target group + wireframes
- We didn't have the time to work out all features that we wanted
- Schema validation
Learning moments
NPM RUN START
did work, but not all functionalities worked.- We had some contact with Rijk, so we learned how to solve certain problems.
- When we wanted to merge some functionalities into the development branch, we had a lot of conflicts. It took a lot of time to solve this.
- When we didn't know how to solve a problem, we asked some other project tech students for help.
- Implement new functionalities (for example, express validator, update profile, file validation)