Juniper Core Changes - PakistanX/edx-platform GitHub Wiki

Welcome to the PakistanX edx-platform wiki! Following are the changes that we've made in the core code, writing here for documentation purposes so that during the upgrade these changes are easily trackable.

1. EDE-1394 Fixing courseware navbar scrolling issue

Reason: We can not avoid it because this issue can only be handled from where the event is triggered and it is in the core JS file.

File path: common/lib/xmodule/xmodule/js/src/sequence/display.js Line number 287

Link to PR: Link to PR and PR 40

2. EDE-1376 Customize success message on password reset form

Reason: We can not avoid this core change because the password reset screen success message can only be handled from where the event is triggered and it is in the core JS file.

File path: lms/static/js/student_account/views/LoginView.js Line number 148-149

Link to PR: Link to PR

3. EDE-1376 Showing modal to the user when they click on social login buttons

Reason: We can not avoid this core change because social button clicks are handle in the backbone so need to add the modal showing code in core files.

File path: lms/static/js/student_account/views/LoginView.js Line number 178-179 & 186-189

Link to PR: Link to PR

4. EDE-1410 Reset password email formatting

Reason: Email button formatting is handled via core code so made a change to change the color of the button

File path: openedx/core/djangoapps/user_authn/templates/user_authn/edx_ace/passwordreset/email/body.html Line number 46-59

Link to PR: Link to PR

5. EDE-1415 User progress tracking issue on Prod

Reason: Problem builder is not supported by edx, that is why it is not marked as completed unless we make this change

File path: edx-platform/openedx/features/course_experience/utils.py Line number 201-206

Link to PR: Link to PR-1, Link to PR-2

6. PKX-96 Reset password email formatting

Reason: Need to display the original error message when the user attempts to click the reset button multiple times

File path: lms/static/js/student_account/views/account_settings_fields.js Line number 187

File path: lms/static/js/views/fields.js Line number 170, 181-185

Link to PR: Link to PR

7. PKX-112 Make breadcrumbs on course about page clickable

Reason: This is not exactly a core change, rather a change of a core change. It is required to make sure that pakx_url_patterns are added at the start of the urlpatterns list. Otherwise, Django would first match the core edx urlpatterns. We want our overridden URL patterns to be matched first.

File path: lms/urls.py Line number 179-181

Link to PR: Link to PR

8. PKX-165 Drag and drop UI changes

Reason: Updated UI of Drag&Drop XBlock and updated requirements to use cloned version

File path: requirements/edx/base.txt Line number 248

File path: requirements/edx/development.txt Line number 326

File path: requirements/edx/github.in Line number 100

File path: requirements/edx/testing.txt Line number 302

Link to PR: Link to PR

9. PKX-180 Add Image Explore & Update py2neo

Reason: Added Image Explorer XBlock in requirements, progress list & updated py2neo because of breakage on Juniper

File path: openedx/features/course_experience/utils.py Line number 204-206

File path: requirements/edx/base.in Line number 15 (removed)

File path: requirements/edx/base.txt Line number 16 & 24

File path: requirements/edx/development.txt Line number 15 & 24

File path: requirements/edx/github.in Line number 62

File path: requirements/edx/testing.txt Line number 15 & 24

Link to PR: Link to PR

  1. PKX-201 Adventure XBlock custom modifications

Reason: Added adventure XBlock in progress list, ADVANCED_PROBLEM_TYPES list, and requirements

File path: cms/envs/common.py Line number 1707-1720

File path: openedx/features/course_experience/utils.py Line number 206 - 208

File path: requirements/edx/base.txt Line number 24-25, 255

File path: requirements/edx/development.txt 24-25, 333

File path: requirements/edx/testing.txt Line number 24-25. 311

Link to PR: Link to PR Link to PR 2

  1. PKX-188 Profile navigation error fix on the Course overview tab

Reason: Needed to add check in main.js and overriding that file didn't work.

File path: lms/static/js/main.js Line number 28

Link to PR: Link to PR

  1. PKX-302 Discovery on Figures

Reason: To disable pylint rule to ignore class & function level docstring missing.

File path: pylintrc Line number 364, 365, spaces from other lines were removed by pyCharm can be ignored

Link to PR: Link to PR