Peer Review Response - L6mps/LasaLaraAP GitHub Wiki

Response to the peer review conducted by Debtsync (found here: link)

Not all of the peer review is responded to in this document. This document only covers problems and questions raised by the reviewer.

Issues

  • GitHub tags/releases do not have descriptive names. We didn’t understand which tags belonged to which iterations. - From this iteration future tags have a descriptive name. In addition, the reviewing team did not ask us which tag they should base their review upon.
  • Clicking “yes” in the last question causes the application to crash. We didn’t find any mention of this bug in wiki or issue tracker. - This has since been fixed.
  • Book.java line 230 (existingChapter.getKey() == updatedChapter.getKey()) : Comparison of two String objects is done using == which compares references not values and is most likely not what is intended. - This has since been fixed.
  • WebRequest.java line 96, 98, 100, 115, 117, 119 (Log.d(StringConstants.APP_NAME, "ParseException: " + e.getStackTrace()); etc) : The logging of e.getStackTrace() logs the reference to the StackTrace object instead of the actual trace, which is most likely what is needed. - Exception handling has since been refactored.
  • WebRequest.java line 100 and 119 (Log.d(StringConstants.APP_NAME, "Jumaliku käe exception: " + e.getStackTrace());) : Logged exception message in Estonian while all other logging is done in English. - Indicating the extraordinary nature of the exception this was at first implemented in Estonian. It has since been fixed.
  • In some places printing exceptions is done in the manner of e.printStackTrace() and in other places similiar cases are handled using the Android logger. - Exception handling has since been refactored.
  • In several places, there are parts of code that are commented out without any explanation (QuestionFragment.java for example) This shouldn’t be present in a release. - Code has since been refactored.

Functional requirements

  • Search for books by the author (owner) of the book and the book title: Not possible to verify/not implemented - Misleading requirement name as explained here
  • Download a book's information to user's device: Not possible to verify/not implemented - This has been implemented some time ago and questions arise over why the reviewer was unable to download a book. It could have been because the reviewer did not know the author and title of any book and did not ask for assistance.
  • View a list of all of the downloaded books: There’s only one book and since it’s displayed properly according to the prototype, this functionality seems to be covered - Once again questions arise over why no new books were downloaded. Regardless, based on our testing this requirement is completed.
  • Navigate through the question queue: Swiping right displays the same question again and swiping left does nothing, not covered - This is a persisting bug.