May 4, 2022 - Islandora/islandora-community GitHub Wiki

Time/Place

This meeting is held virtually via Zoom, with an open channel for chatter on Slack. Anyone is welcome to join. The hosting can be claimed by anybody with the host ID. The Host ID is in the header of the TAG slack channel.

• Time: 1:00pm Eastern Time US (UTC-5)
• Zoom link: https://zoom.us/j/97345581392
• Passcode: 919241
• Join us on the Slack Islandora Channel https://islandora.slack.com/archives/CM5PPAV28

Chair Roster

These are the core members of TAG and will take on chair of the meeting if there are no volunteers, and will support volunteers who are chairing for the first time:

• Don
• Seth 🪑
• Rosie
• Willow

Attendees

• Seth Shaw (Chair)
• Alan Stanley
• Rosie Le Faive
• Yamil Suarez
• Jordan Dukart
• Adam Vessey
• Alexander O'Neill
• Willow Gillingham
• Tom Misilo
• Melissa Anez
• Isabella Nikolaidis (notes)

Agenda

Note that links are to the document repository only. New issues in other repositories or organizations will not appear in this list, and should be added by interested parties directly to the agenda.

1. IslandoraCon Call for Proposals form closes May 15 - make your submissions!
2. Call to complete the Islandora Migration Event Survey - fill it out if you have not done so already!
3. Issue Roundup - Link sorted by date
4. PR Roundup- Link sorted by date
5. Feel free to add more, or add something from Islandora Discussions

Minutes

Issue Roundup

• https://github.com/Islandora-Devops/isle-buildkit/issues/213

  • Nigel and Gavin are working on this

• https://github.com/Islandora/documentation/issues/2102

  • Isabella to update website links accordingly to include a .ics link

• https://github.com/Islandora/documentation/issues/2100

  • Willow: The facets javascript comes in and trims the results to what you've configured, hides the other results. Islandora advanced search javascript breaks that.
    • Is it not getting the same containers? Not sure.
    • If I take their javascript away, facets work again.
    • Shouldn't be overwriting that soft limits module attached.
  • Jordan: Nigel had rewrote the facets javascript because it has a lot of problems when you start looking at Ajax
    • Not sure if completely removing that would be viable, because it impacts queries to selenium
  • To follow up with Nigel
  • Seth: Leave issue open and tag Nigel for more conversation.
  • Adam:
    • Nigel's justification: https://github.com/Islandora/islandora/blob/2.x/modules/islandora_advanced_search/js/facets/soft-limit.js#L5

• https://github.com/Islandora/documentation/issues/2099

  • merged

• https://github.com/Islandora-Devops/islandora-playbook/issues/215

  • this issue reports on a note required in the documentation

• Alexander: Best practices question - creating a PR directly, without creating an issue

  • If a PR is a standalone fix especially, may not make sense to link in unnecessarily-created issue.
  • Links to other related issues OR discussions on slack can also be linked in PRs when relevant.
  • Making and linking in issues was more useful before PR Roundup implemented.
  • Alan: Thinking of issue queue as meant for reporting bugs that are outside of one's expertise

Pull Request Roundup

• https://github.com/Islandora-Devops/islandora-playbook/pull/216

  • Jordan to test

• https://github.com/Islandora/islandora/pull/869

  • Alexander to revisit

• https://github.com/Islandora/islandora_defaults/pull/66

  • Ready to test
  • Steps(?): Do make local, get codebase, go into web modules, shift out islandora defaults, bring out the new config. Copy the config from the module into your config sync.
  • Can do this on install profile build, make profile.
  • Yamil will follow up with testing questions

A set of related PRs:

• Approach: Apply 252, make sure it still starts up, and then follow the instructions for 253.

• https://github.com/Islandora-Devops/isle-dc/pull/252

  • Tom: performed on systems, and behaved as expected
  • This lets you use other providers, other than Lets Encrypt.
  • InCommon, Internettoo are some other SSL providers.
  • All this does is verify the account and mint a new certificate.

• https://github.com/Islandora-Devops/isle-dc/pull/253

  • More details on how to test here.

• https://github.com/Islandora/documentation/pull/2096

  • Waiting on 2053.

• https://github.com/Islandora/documentation/pull/2095

  • Documentation changes to reflect certificate details.

Other items for follow up:

• https://github.com/Islandora-Devops/isle-dc/pull/247

  • Alexander: Nick Ruest approved some Crayfish Commons stuff, is it ready to merge?
  • https://github.com/Islandora/Crayfish-Commons/pull/49#pullrequestreview-953796506

• https://github.com/Islandora-Devops/islandora_install_profile_demo/pull/11

  • Rosie: This has been sitting for a while
    • The stack for install profile has gotten complicated
  • Changes are in the demo profile module
  • To test
    • If Ansible playbook, there's a variable you can set to install profile demo.
      • Ansible doesn't work so well on Windows
      • Can use WSL?
    • If ISLE DC, you would need to get your isle dc to point to the fork of sandbox
  • Rosie: In the makefile, it does a git clone of islandora sandbox? Will follow up and post in PR.