classic_backporting todo zero commits - Flowy/cmangosDB GitHub Wiki

• zero 4d68c37 * Salja (committer Salja)

  [z1798] Combustion (remove main aura) and (remove triggered aura stack) by Unlern Talents.
    91.2% src/game/
     8.7% src/shared/

[OK] cala : Tested on z2040, without this fix it is possible to take advantage of the unlearn mechanics to use combustion aura even after unlearning the talent. This commit fixes it.

• zero b7a8540 * Sidsukana (committer Sidsukana)

  [z1799] Remove extra mods code.
    87.7% src/game/extras/
     5.3% src/game/
     6.3% src/mangosd/

[REMOVE] cala : see commit below

• zero 139075f * TheLuda (committer TheLuda)

  [z1800] Remove all remains of TBC spell modifications.
    37.3% src/game/
    43.9% win/VC100/
    18.7% win/VC90/

[REMOVE] cala : this one and the previous one are correct. In their current state, mods are needed for two purposes: TBC PvP diminishing returns (no need for classic) and modifying a paladin spell. This last one is moved into core by previous commit. If it is not broken, don’t fix it.

• zero 482ca12 * Sidsukana (committer Sidsukana)

  [z1805] Fix Improved Sprint.
    76.2% src/game/
    23.7% src/shared/

[OK] cala : This one looks ok but I will test it because I’m surprised it is not fixed in TBC also.
On z2194, improved sprint is indeed broken (not working and breaking sprint along). This commit fixes it.
This commit does also the job. I don’t know which one is better: new zero

• zero 84e3d1c * Sidsukana (committer Sidsukana)

  [z1807] Fix spell 6346.
    51.2% sql/updates/
    18.4% sql/
    30.2% src/shared/

[OK] cala : This one is OK but this is only for DB. No need to backport to core. I’ll put it into DB if not already there.
stfx: There are some tables which are managed by mangos and not the database providers. this one is one of them.
cala : tested on z2194 (and mangos-zero DB), this spell is already flagged as intented. This commit should be applied nonetheless to keep track of the fix.

• zero f026561 * Cala Haryon (committer Cala Haryon)

  Modify the mana regeneration rate to be correct for 1.12 and below.
   100.0% src/game/

[OK] cala : this one is only half correct. The mana regen should occur every 2 sec See * Mana regenaration *, so the part fixed by this commit is correct. However, the mana regen formula was not the same for all spell casters in 1.12, it was uniformed in 2.4. I will propose a fix later to this issue and document it. In the meantime, I advice to still apply this commit, at least it will prevent casters from gaining mana twice faster than expected

FILE LAST UPDATED BASED ON… zero 9293a6d * TheLuda (committer TheLuda)