Maintaining Database - Cxbx-Reloaded/XbSymbolDatabase GitHub Wiki
NOTE: Be sure to follow thoroughly with OOVPA signature guideline.
Add new founding symbol(s) or variant of symbol ABI
- Add xref name in a
xxxx.def
file frominclude/xref/
directory. - Create OOVPA signature in
src/OOVPADatabase/XXX/####.inl
file respectfully. - Add OOVPA register into
src/OOVPADatabase/XXX_OOVPA.inl
file. - Add xref register into
src/test/libverify/XXX.cpp
file. - Go to Before Create Pull Request step.
If none of above are done correctly, then pull request creation will report failures.
Add detection to existing symbol
- Create OOVPA signature in
src/OOVPADatabase/XXX/####.inl
file respectfully. - Append OOVPA register into
src/OOVPADatabase/XXX_OOVPA.inl
file. - Update xref register into
src/test/libverify/XXX.cpp
file if necessary. - Go to Before Create Pull Request step.
Before Create Pull Request
- Run unit test tool to verify implementation is working as intended.
- NOTE: XbSymbolDatabaseUnitTest provide ability to recognize if new symbols are detected. Assuming you have perform previous test stored into cache. Otherwise, you can also look into cache folder to search for specific symbols.
- Verify codebase are clang-formatted and saved into commit.
- Make sure OOVPA signature guideline has been followed thoroughly.
- Finally, create pull request to integrate either existing or new symbols into XbSymbolDatabase.
If none of above are done correctly, then pull request creation will report failures.