V2 Manifest ‐ Unused Code - CameronD73/529renew GitHub Wiki

This will list the sections of code that will not be supported in version 3. The main cause would be where the function has been made redundant by changes in the 23 and me web mages.

Build 36

This is presumably obsolete data that can no longer be added to. Any results should have been exported long ago, so I propose any code supporting build 36 be removed. If they ever move to build 38 we will need to work out how to accommodate that at that time.

Phase, Relationship and Comments (Ancestors)

  • I don't clearly understand how phase and relationship fields are intended to be used in the segment table. They are entered manually into the boxes when displayMode is set to Edit phasing and Ancestors. However, they really only make sense when this DB applies to only a single DNA tester. Consider - I manage two profiles: mine and my mother's. A person who matches my mother's paternal side will be phased M for me but P for my mother's kit. To do this unambiguously would probably need a separate table in the database.
  • phase is available in some cases from 23 and me (when either parent has tested). 529 code does not collect this data, even though it is available on the original page. (However I don't know how to access it).
  • Notes that you may have attached to matches are available and could be saved to comments but are not.
  • both phase and notes are available in the csv download from 23 and me, so there is less need for 529 to collect them as well. relationships (as well as phase and notes are much better handled in GDAT, so if that is the only purpose for these fields then it is much better to ignore them. Or even remove them.