System Message Timestamp - CSCI-462-01-2021/Fork-Bomb GitHub Wiki

Show timestamp on system messages after a tap - #1143 (habitica-android)

Status:

  • Isabel: Request to be assigned to issue (2.4)
  • Isabel Lally assigned to issue (2.4)
  • Pull Request Submitted (2.9)
  • Pull Request (Accepted/Rejected) (ADD DATE)

Notes:

  • UI should follow this format:

  • File Notes:

    • Habitica/src/main/java/com/habitrpg/android/habitica/ui/adapter/social/ChatRecyclerViewAdapter.kt

       
    • Habitica/res/layout/system_chat_message.xml
    • Habitica/src/main/java/com/habitrpg/android/habitica/models/social/ChatMessage.kt
  • System message does contain a timestamp attribute formatted as: "timestamp":1612818237407 (epoch time)

Changes:

  • Changes Made (branch):
    • Habitica/src/main/java/com/habitrpg/android/habitica/ui/adapter/social/ChatRecyclerViewAdapter.kt
    • Habitica/res/layout/system_chat_message.xml Added:

Roadblocks:

  • Habitica/src/main/java/com/habitrpg/android/habitica/ui/adapter/social/ChatRecyclerViewAdapter.kt
    • line 127: warning Type Mismatch Required: Date Found: Date?
    • unsure at moment if this type of warning is actually problematic
      • appears to be a common warning
      • !! may fix
        • appears to be an unsafe method of removing warning and since the same type of warning exists elsewhere, leaving alone for now

Feedback:

  • Add back in .example files
  • Recheck variable names
  • See what happens when fixing warning (!!)

Results:

Pull Request

  • Feedback on pull request to fix formatting (2.26)
    • Need to look into android code format to figure out what exactly that means
    • Appears to just be formatting of if/else statement not matching code style