When you try to PM an account that has been deleted, an error should show - #1401 (habitica-android)

Status:

• Ashley: Create account to be deleted (DoomedTester2021, @DoomedTester2021) (1.26)
• Ashley Woods assigned to issue (2.2)
• Fix created and in testing (2.11)
• Pull Request Submitted by Ashley (TBD)
• Pull Request (Accepted/Rejected) (TBD)

Notes:

• Pop-up for this should follow this format:
  

• Message info:

  • From?
  • To?
  • Do messages currently have statuses? (pending, delivered, etc)
  • How are they routed?
  • User statuses? (active, inactive, etc)
    • Do other features know whether a user is active or inactive?
  • Does web UI have this issue or just android?
    • Is it client-side or server-side? (Habitica has a server repo)

• Where else uses this popup?

• File Notes:

  • Habitica/src/main/java/com/habitrpg/android/habitica/api/ApiService.kt
  • Habitica/src/main/java/com/habitrpg/android/habitica/data/implementation/ApiClientImpl.kt
  • Habitica/src/main/java/com/habitrpg/android/habitica/data/ApiClient.kt
  • Habitica/src/main/java/com/habitrpg/android/habitica/data/implementation/SocialRepositoryImpl.kt
  • Habitica/src/main/java/com/habitrpg/android/habitica/data/SocialRepository.kt
  • Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/social/InboxMessageListFragment.kt ~Line 197
  • Habitica/src/main/java/com/habitrpg/android/habitica/ui/views/dialogs/HabiticaAlertDialog.kt For use in building the pop up

Changes:

• Code Before Change: (2.2)
  

• Code After Change (see lines 200-206): (2.11)
  

Feedback:

• TBD

---

Results:

• Pop up displayed on the phone: (2.11)
  

Pull Request (2.16)

---

Future questions

• Going to re-create user does not indicate that username from deleted account is taken
  • Are there other issues related to this? (party, messaging a revived account (to new owner), etc)
• Setting to disable private messages
  • How (if at all) does this play into deleted user?