Project Part 2 Feedback - CMPUT301W13T05/ClassProject GitHub Wiki
Feedback
Requirements Specification -- Excellent (3)
- Table of contents: 'Pulish' -> 'Publish'.
- The outline looks very good!
- Indicated corresponding use stories. Good!
- UC1: 'System let' -> 'System lets'. For basic flow, usually, we say 'user enters blablabla...', 'user clicks the save button', 'system displays blablabla....'.
- UC3: basic flow, before pressing 'upload' button, user needs to select at least one recipe or create a new one, right? So, better to put it before basic flow 1. System publishes the recipe to webservice, not Gson:).
- The use cases look good in general except some subtle problems. Please update the doc based on the feedback.
- Test cases are included too.
User Interface Mockups and Storyboard -- Excellent (3)
- 'User will get this screen first when he start this app.' -> 'he starts'.
- Where is 'Setup Search' button in home page?
- UI looks good. Important use cases are covered.
- The storyboard tells the story clearly and interestingly. Good.
OOA -- Good (1)
- Colored labels to indicate M, V, C classes. Good.
- Model classes: the directed association seems not correct. The arrow should indicate container-contained relations. So, in your case, 'Photo' contains 'PhotoAlbum'? Please refer to http://creately.com/blog/diagrams/class-diagram-relationships/#Directed. Also, the name of classes starts with capital letter. 'photo' -> 'Photo'...
- Controller classes: 'recipe...' -> 'Recipe..'
- Viewer classes: 'takePhoto..' -> 'TakePhoto...'
Release Planning -- Excellent (1)
Glossary -- Excellent (1)
- LICENSE included.
- Glossary clarified.
- Other references included.
Summary -- (9)
- Good job!