Project Part 3 Feedback - CMPUT301W13T03/classproject GitHub Wiki

Feedback

Code base of Prototype -- Good (2)

  • The code is very clear and well organized.
  • Consistent with the design.
  • At least 1/2 requirement has been implemented.
  • Are you using file to save recipes? Usually, we use database, like SQLite to save the data. The operations in database are optimized. And with more data in your file, it won't be easy and fast to search by comparing strings. If possible, please use database.

Tangible Demo -- Excellent(1)

  • Demo is clear.
  • Basic functions have been implemented.

Code Documentation -- Excellent (1)

  • Javadoc looks good!
  • Clear description of classes, methods, params, return values, etc.
  • Well done.

Test Cases -- Good (2)

  • Instead of putting many 'assert' into one test case, you can put them into several test cases so that it is easy to tell which 'assert' fails. Otherwise, you still need to find out the 'failure' cases by yourself.
  • Test cases look good in general.

OOD -- Excellent (2)

  • The text above RecipeApplication is mixed.
  • The diagram looks good, M, V, C are all clear.
  • Keep updating the diagram :)

Release Planning -- Excellent (1)

Addressing Feedback -- Excellent (1)

  • Thank you for your attention!

Summary -- (10)