Project Part 3

Code base: Excellent, +3

• Use GSON or another java->json library not Serializable.

  • The output json should reflect your model upon examination by a human (JSON is text).
  • Should eliminate the need for things like ObjectType

• Fix (at least comment out, preferably remove) unused variables.

• Fix other warnings (check the problems pane!)

• Some broken android bits: check the android lint tool!

Demo: Good, +1

• Begin reading button crashes the app for built in story but works after adding a new story on that story
• Not particularly clear when the story actually gets created / can I decline to make the first chapter right away?

Documentation: Good, +1

• Adapters missing documentation
• Avoid parrot documentation: yes getID obviously gets the ID of the chapter... give an example or more details! (Where does the UUID come from? Where does it go? What it is it useful for? What does it look like?)
  • That is just one example, there are many such cases.

Test Cases: Excellent, +2

• Remove org.junit dependencies
• A few public methods missing tests (toString)

OOD: Good, +1

• Methods that do formatting like toString should be in Views not Models
• Some typing over your lines, clean that up (eg (0..*) on top of lines)

Release Planning: Excellent, +1

Addressing Feedback: Good, +1

Total: 10/10