Project Part 2 Feedback - CMPUT301F13T13/StoryHoard GitHub Wiki

Use Cases: Excellent, +3

  • No specific use case for searching for a story (though it is, indirectly, tested). Fix this.

  • No specific testing that the story fragments are indeed stored offline. Fix this.

  • Use Case 13 and similar:

    • Suggest you write tests that at least check that the activity has the correct widgets instantiated, and that they have images in them, etc. For example, on a fragment with 3 images, check for 3 image widgets and see if you can get their images back out of them, and they are not null. Or, if you want to get fancy: http://developer.android.com/tools/testing/testing_ui.html

User Interface Mockups and Storyboard: Excellent, +3

  • PUT YOUR IMAGES IN GIT Photobucket is not acceptable.
  • Label your storyboards with specific user story or use cases by number.
  • Mockups:
    • How do I search?

OOA: Excellent, +2

  • Don't use light colours on white background (light pink, yellow).
  • How does your choice controller talk to a choice? They are not connected...
  • Specify relationship directions: Does the controller know about the view? Does the view know about the controller? No arrows means both know about each other is this what you want for every Controller/View pairing?
  • Is addChapterActivity really a view? Think about it.

Release Planning: Excellent +1

  • Consider what use cases depend on what other use cases! Other than that, looking good, get crackin'.

Glossary: Good +1

  • Publish and cached both link to the definition of browse, fix it.
  • Save: clarify what you mean by "local device" the reference you cited says "storage device" is this the same thing?

Total: 10/10