Project Part 3 Feedback - CMPUT301F12T01/classproject GitHub Wiki

1. Summary

Code base of prototype: Satisfactory 1/3

Demo: Good 1/1

Code documentation: Good 1/1

Test cases: Satisfactory 1/2

OOD: Satisfactory 1/2

Release planning: Excellent 1/1

Addressing feedback: Excellent 1/1

In total: 7/11

This is based on the rubric in https://eclass.srv.ualberta.ca/mod/resource/view.php?id=326268. If you have any concerns please email me (chenlei.zhang AT ualberta.ca).

2. Code base of prototype [Satisfactory]

The team finished less than half of the project. The code looks clean and clear. It was good to have different packages for storing different kinds of classes.

3. Tangible demo [Good]

The application is demonstrable, but it was rough.

4. Code documentation [Good]

The code documentation is mostly consistent and easy to interpret. Please remove the javadoc of the classes in gen package.

5. Test cases [Satisfactory]

There are some test cases but it is not enough. The test cases should test all the interface of the model. Besides, please add enough comments in your testing code too.

6. OOD [Satisfactory]

The diagram is not evolving with your implementation and inconsistent with your code. Also there was no notes on the use of design patterns among the classes. Please add this.

7. Release planning [Excellent]

The release planning is clear.

8. Addressing feedback [Excellent]

The feedback was addressed.