Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql should use utf8 #225

Merged
merged 1 commit into from Mar 11, 2016
Merged

Conversation

lifeofguenter
Copy link
Contributor

There is no reason nowadays for MySQL tables to not have utf8 as charset - especially the connection of the client should "talk utf8".

The pages already make usage of utf8 (via header + html).

This might not be backward compatible (for example if you were using non-ascii chars as username).

lifeofguenter added a commit to phpmyzone/phpmyzone that referenced this pull request Jun 28, 2015
@edmondas edmondas added this to the v2.1.8 milestone Jul 2, 2015
@edmondas edmondas self-assigned this Jul 2, 2015
@SebTM SebTM added the question Further information is requested label Mar 9, 2016
@SebTM
Copy link
Contributor

SebTM commented Mar 9, 2016

I think switching to utf8 is an important step for v2.1.8 so we should do this. Is it enough just to warn the user in README and update-script that we are switching to utf8 and he have to take care of his users before? What about the other database-systems - do we need to change something here? I'm not familiar with pgsql etc.

@edmondas
Copy link
Contributor

edmondas commented Mar 9, 2016

In my opinion there's work that's need to be done, because I prefer to keep backward compatibility just not to make existing users angry about new version that breaks everything. My plan is:

  1. Add config variable for db encoding (default value will be latin1)
  2. Add encoding/collation selection to installer
  3. Add support for other databases (pgsql and sqlite)

@edmondas
Copy link
Contributor

It seems that it would take time to implement everything that I wrote above, so I will merge it and just cleanup it a bit to keep backward compatibility.

edmondas pushed a commit that referenced this pull request Mar 11, 2016
@edmondas edmondas merged commit 2d92602 into poweradmin:master Mar 11, 2016
@edmondas edmondas removed the question Further information is requested label Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants