Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple masters not allowed when adding a new slave zone #217

Closed
ajoaoff opened this issue Nov 26, 2014 · 3 comments
Closed

Multiple masters not allowed when adding a new slave zone #217

ajoaoff opened this issue Nov 26, 2014 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@ajoaoff
Copy link

ajoaoff commented Nov 26, 2014

When you try to add a new slave zone with multiple masters, you receive a message saying it's not a valid IPv4 or IPv6. The function that checks if the user entered a comma-separated list of IPs is called only when changing the zone, not when adding.

@stasic
Copy link
Contributor

stasic commented Nov 27, 2014

Please pull the latest commit and try if it fixes you issue.

@ajoaoff
Copy link
Author

ajoaoff commented Nov 27, 2014

Thanks, it worked. But the change you made to is_valid_ipv4 should be done to is_valid_ipv6 too, I think.

@stasic
Copy link
Contributor

stasic commented Nov 27, 2014

The change I made was needed for this bugfix, but it is not really related to you issue. Anyway you are right and it should be done -> take a look at latest commit: 4dfc943
Thanks for reporting this issue.

@stasic stasic closed this as completed Nov 27, 2014
@edmondas edmondas added the bug Something isn't working label May 5, 2015
@edmondas edmondas added this to the v2.1.8 milestone May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants