Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerAdmin does not hide DNSSEC empty rows #194

Closed
croessner opened this issue Aug 11, 2014 · 2 comments · Fixed by #212
Closed

PowerAdmin does not hide DNSSEC empty rows #194

croessner opened this issue Aug 11, 2014 · 2 comments · Fixed by #212
Labels
bug Something isn't working
Milestone
v2.1.8

Comments

@croessner
Copy link

Hi,

I first thought it was a PowerDNS bug, but they just closed it and said that PowerAdmin would have a bug.

PowerDNS/pdns#1661
@croessner
Copy link
Author

I have not done PHP for a very, very long time. I tried to find a solution. Here is, what I changed:

Maybe you like to review this.

I don't know, how to attach a file here. So I place it on my server under:
http://www.roessner-network-solutions.com/record.inc.php.diff

@ghost ghost added the analysing label Aug 12, 2014
@ghost ghost added this to the v2.1.8 milestone Aug 12, 2014
@ghost ghost self-assigned this Aug 12, 2014
@ghost ghost added defect and removed analysing labels Aug 12, 2014
@ghost ghost closed this as completed in c06b67b Aug 12, 2014
@ghost
Copy link

ghost commented Aug 12, 2014

@croessner thanks for patch.

ktims pushed a commit to ktims/poweradmin that referenced this issue Sep 25, 2014
Avoid querying for pdnssec ordering records at all
633ea02 
Add "WHERE" filters for TYPE IS NULL to record queries
Previous fix in Fix poweradmin#194 only hides them from display, which
results in empty pages, incorrect pagination and random numbers
of records per page. PowerAdmin shouldn't need to see these at all
so filter them at SQL.
@ktims ktims mentioned this issue Sep 25, 2014
Closed
@ktims ktims mentioned this issue Oct 24, 2014
Merged
@qoreQyaS qoreQyaS mentioned this issue Apr 29, 2019
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.1.8
1 participant
@croessner