Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic_update.php missing soa serial increment #181

Closed
petzsch opened this issue Jun 26, 2014 · 2 comments
Closed

dynamic_update.php missing soa serial increment #181

petzsch opened this issue Jun 26, 2014 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@petzsch
Copy link

petzsch commented Jun 26, 2014

Here my proposed changes that work for me:

add:
require_once("inc/toolkit.inc.php");
remove:
require('inc/config.inc.php');
require('inc/database.inc.php');

below these lines:
$update_result = $db->query($update_query);
$was_updated = true;

add:
update_soa_serial($zone["domain_id"]);

@petzsch
Copy link
Author

petzsch commented Jun 26, 2014

sorry, ran into a session issue while testing. can't include toolbox.inc.php as it requires an active session.

Helped myself with copying the set_timezone function out of toolbox.inc.php in the dynamic_update.php and using this set if includes:

require('inc/config.inc.php');
require('inc/database.inc.php');
require('inc/record.inc.php');

@ghost ghost added the defect label Jun 27, 2014
@ghost ghost added this to the v2.1.7 milestone Jun 27, 2014
@ghost ghost self-assigned this Jun 27, 2014
@ghost ghost added In development and removed In development labels Jun 30, 2014
@ghost ghost removed this from the v2.1.7 milestone Jul 1, 2014
@ghost ghost added analysing and removed defect labels Jul 1, 2014
@ghost ghost added this to the v2.1.8 milestone Jul 1, 2014
@sj
Copy link

sj commented Sep 30, 2014

@petzsch' suggestion solved this problem for me. It'd be better to have the set_timezone function in an accessible place (i.e., where an active session is not required) to avoid code duplication, but apart from that I think this is the way forward.

@petzsch petzsch unassigned ghost Oct 26, 2014
@edmondas edmondas added bug Something isn't working and removed analysing labels Oct 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants