Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol version #4568

Open
shamisp opened this issue Dec 11, 2019 · 2 comments
Open

Symbol version #4568

shamisp opened this issue Dec 11, 2019 · 2 comments

Comments

@shamisp
Copy link
Contributor

shamisp commented Dec 11, 2019

https://doc.dpdk.org/guides-16.04/contributing/versioning.html

I suggest to adopt similar guidelines. @yosefe - it actually inline with the API versioning that we discussed today. Sympbo.map just automates the process and will provide us with much more flexibility on ABI side.

@jgunthorpe - is this similar to what you have in rdma-core.

@jgunthorpe
Copy link
Contributor

rdma-core doesn't have so much for deprecating symbols, we are a system library so symbols are forever.

But that is a good explanation how to use symbol versions. Both dpdk and rdma-core have the various macros to make it work.

@shamisp
Copy link
Contributor Author

shamisp commented Dec 11, 2019

@jgunthorpe - we do have deprecated APIs that we will want to remove at some point...hopefully. Macro - we would probably prefer to borrow it from RDMA core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants