Web conference notes, 2021.09.09 (MDS Working Group)
MDS Working Group
- Weekly Thursday call at 9am PT / 12pm ET / 6pm CET
Meeting ID: 841 7098 9462 - Passcode 612987
https://us02web.zoom.us/j/84170989462?pwd=WTRlY25wOVhNeS8wQk1iM2QzYkQvUT09
One tap mobile: +19294362866,,84170989462#,,,,*612987# US (New York)
Dial by phone: +1 929 436 2866 (US) (Find your local number)
Note: We are now collecting attendees upon entry into the Zoom meeting. An attendee count will be posted here after the meeting:
19 Attendees
Main Topics
- Finish open Policy issues/PRs for 1.2
WGSC Meeting Organizers
- Host: Michael Schnuerle
- Facilitator: Jascha Franklin-Hodge
- Outreach: Michael Schnuerle
- Note taker: Michael Schnuerle
- Thanks to POPULUS and E&A for their contributions
- Remove rate as rule type 662 - please review for next release and breaking change
- DONE: Flagged as 2.0
- Add hierarchy/grouping to policy rules 663 - breaking change for next release
- DONE: Flagged as 2.0
- Matt Davis create examples for 688 to account for min/max
- TODO: Matt Davis
- Michael send link to template schema for PR
- DONE: here is link to schema template location for policy
- TODO: Matt Davis incorporate into PR(s)
- For 599 Neil could open a new Issue for 2.0 for breaking changes with additional context
- TODO: Neil make new Issue for 2.0
PR 688 add rate_applies_when field to policy rules
-
Optional defaults to out_of_bounds to make it non breaking
-
Neil likes, fills gap
-
Matt needs to check examples, account for this
-
None of the examples have min and max
-
Neil didn’t have bounding much in examples
-
Michael will comment notes and work into 1.2 release.
-
Sebastian - wants to keep it simple, could we define it in another way?
-
Bounds only used with rule min and max
-
Matching rules in order is not part of this PR
-
If that rule has a rate, question is whether the rate is applied you can’t not match a rule
-
Could clarify matching based on current setup - a match means that rule applies
-
If you don’t match anything then what happens - nothing happens!
-
Parking policy - riding scooter, match rule and still
-
Matt note: Rule min and max are not used to match event to a rule.
-
For 2.0 split up logical criteria, then define bounds for that rule. What defines what could fit, and what exceeds bounds separately.
-
Applies_to to see if you match, then check rule_parameters, then check rate.
PR 677 vs 689
Allow users to specify rule min/max treatment vs Clarify policy rule min and max are inclusive
677 - note to always make min or max inclusive
- Flexibility of choice, express it intuitively, gets written into schema
- Neil: Doesn’t break anything
- Accounts for greater than or greater than and equals
- May reduce rule writing complexity
- Adds yet more rules to fields, so nesting is more valuable
- Likely go with 689
- [] ms Template schema point to where
689 - allows inclusive_min and inclusive_max that default to true
Zack - example when exclusion applies
- Matt add example to PR
- A count rule with a min and max, then a rate of 50 cents per vehicle, then applies when out of bounds. When in bounds, min of 500 and max of infinity.
693 - Align Policy JSON Schema & Examples with spec
and
599 - Response when returning a single object is not clear
- Align examples and schema to use policies not policy
- Could open a new Issue for 2.0 for change in additional context.
- Fixing what’s wrong from initial release.
- Looks good, agreement all around
- Keep open for a week then merge
654 - New field for counting instead of currency
- Frederick Robinet surfaced this discussion issue
- Wanted to not have currency be ISO in feed. Change to a string to allow any value or integer.
- But may be better to add a new field for this.
- Need to make PR in next week if wanted to include in 1.2, otherwise for 2.0.
