Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Remove deprecated --params option #888

Closed
ChrisMaddock opened this issue Jan 30, 2021 · 8 comments · Fixed by #1151
Closed

v4: Remove deprecated --params option #888

ChrisMaddock opened this issue Jan 30, 2021 · 8 comments · Fixed by #1151
Assignees
Milestone

Comments

@ChrisMaddock
Copy link
Member

No description provided.

@GitClickOk
Copy link

GitClickOk commented Mar 25, 2021

@ChrisMaddock, I see here since the 3.10 version the --params option is deprecated in favor of --testparam option. Please, update the docs then, there is no reference to --testparam option, and nothing about syntax too. The deprecation note will be nice too.

PS: (If the docs are open source, and if you want I can try contribute and update myself)

@ChrisMaddock
Copy link
Member Author

Hi @GitClickOk - a contribution to the docs would be really appreciated! Just click the "Improve this Doc" link in the top right of the page, which will take you to the relevant GitHub repo. 🙂 Let us know if you have any problems.

@GitClickOk
Copy link

GitClickOk commented Apr 3, 2021

@ChrisMaddock FYI I have created a PR for suggested change in the docs. I saw the markdown was broken in --param option and I have fixed too: nunit/docs#555

I hope is everything ok, this is the first time I create a PR in GitHub, I work only with BitBucket :)

@ChrisMaddock
Copy link
Member Author

That looks great - thanks @GitClickOk! Appreciate the help! 😄

@CharliePoole
Copy link
Contributor

@jnm2 @mikkelbu @rprouse

Since we are breaking things for 4.0 anyway, my inclination is to use the syntax and implementation of --testParams but go back the original naming of --params. What do you think?

@jnm2
Copy link
Collaborator

jnm2 commented Feb 18, 2022

I'm fine with it.

@CharliePoole CharliePoole self-assigned this Feb 18, 2022
@CharliePoole CharliePoole removed the Idea label Feb 18, 2022
@rprouse
Copy link
Member

rprouse commented Feb 18, 2022

I'm good with it too. Are we planning on using a different executable name for 4?

@CharliePoole
Copy link
Contributor

I never thought about it but obviously nunit3-console isn't good any more! I'll make an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants