Grails Engineering Meeting Notes (11 05 2020) - grails/grails-core GitHub Wiki

Date: 11/05/2020

Attendees

• Puneet Behl
• David Estes
• Jason Schindler

Agenda

• Current Grails Development Activities
• Discuss the correct channel to move the JFrog feed information out from the development channel.
• Open Discussion

Current Development Activities

David

• 4.0.5 is out
• Making progress on the CSRF stuff but is trying to determine where it belongs. Probably in the web plugin
• i18n is including ant dependency and is causing a critical warning on any Grails app
  • Will try to strip the dependency to see if things work without the ant dependency
  • This should be done for both 4.0.x and 4.1.x
    • Puneet: We should bump the version for 4.0.x and see if we can remove it entirely for 4.1.x
  • We should consider including a security scan in the build automation in the future
    • Puneet: There are a lot of changes to build things that I'd like to do like moving away from Travis
• Continuing to answer asset pipeline questions

Puneet

• Grails 4.0.4 was released with wrong version of GORM in the pom
  • To fix it, you need to bump the GORM version manually
  • This has been fixed in 4.0.5, but we still see issues coming in. What should we do?
    • David: I think we just need to give people some time to switch to 4.0.5
    • Puneet: I'll continue to close them
• Working on issues in Grails 4
  • There are issues with Spring Cloud (https://github.com/grails/grails-core/issues/11587)
  • Fixed some issues with reloading Micronaut HTTP Client
    • This will go in both 4.0 and 4.1
  • Multipartresolver exception handling does not work (https://github.com/grails/grails-core/issues/10928)
    • We need to fix this
      • David: This is similar to issues I see with a user aborting the connection
      • David: Maybe we can do this with a filter bean
      • Puneet: Can you point me to the other issue that you think is similar to this after the meeting?
      • David: It is basically that ConnectionAborted Exceptions flood your log some times. I'll create an issue for it
• Regarding Grails 4.1.0, there is a bug with Micronaut Spring where there are conflicts with the method interceptor.
• Working on ability to use declarative Micronaut HTTP Client for tests and injecting directly in the test

JFrog Feed in Slack

• Puneet: In the development channel there are a lot of alerts for JFrog notifications and they are not related to development
• Puneet: I'll create a new alerts channel and notify users in existing channel of the change

Open Discussion

Move from repo.grails.org to JCenter

• David: We need to slowly move off of repo.grails.org.
• David: I've moved my stuff to JCenter
• David: We can keep it around for a while but new projects should use JCenter

Long build times in Grails 4

• David: I sent an image in the committers channel showing that build times are about double from Grails 3 to 4.
  • Puneet: Can you try defining Gradle opts in gradle.properties and adding an Xmx?
  • Puneet: Also, verify that Gradle Daemon is on
    • David: We explicitly turned Gradle Daemon off
  • Puneet: We need to dig deeper to see what is going on. Can you send us a sample app?
  • David: I think it might be something in Groovy but I'm not sure

Reading encrypted configurations

• Puneet: Working to try and read encrypted configurations
  • Using this: https://github.com/ulisesbocchio/jasypt-spring-boot
  • Puneet: I think we should be able to update the Jasypt Grails plugin to handle this behavior
  • David: We did this on our own and used the same enc syntax

Time Change

• Puneet: Due to the US Central DST change, this meeting is now an hour later
  • Jason: I'll put a message in Slack to ask about moving this meeting an hour earlier