Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write protect the master branch #64

Closed
danielsclint opened this issue Mar 16, 2016 · 1 comment
Closed

Write protect the master branch #64

danielsclint opened this issue Mar 16, 2016 · 1 comment
Assignees

Comments

@danielsclint
Copy link

The master branch needs to be write protected to only allow pull requests after automated testing is completed and passed.

@toliwaga
Copy link
Contributor

Master branch is write protected and requires passing travis tests for pull requests. I have not enabled a coverage threshold or coverage decrease threshold because I wasn't sure I could set different thresholds for master and other branches and wanted to wait to see what kind of fluctuation in coverage we might tolerate making branches available between developers during active development. Though I guess we could set the bar pretty low (like 95%) with no problem. In any case I am getting slack notifications and of course run the tests before any commit so this is probably a less urgent issue, unless anyone has strong feelings about the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants