Skip to content

Code Reviews

Beat Buesser edited this page Oct 3, 2021 · 3 revisions
  1. Pull request require approval by a reviewers assigned by one of the maintainers.

  2. Approved pull requests will be merged by one of the maintainers.

  3. Reviewers should aim to understand every change of code and ask what the changes goals are and how it accomplishes them.

  4. Reviewers should not assume that the code works, but should run and test it themselves.

  5. Reviewers should comment code and ask questions, especially to detect cases where intent does not match code logic, etc.

  6. Reviewers should consider all code as production code.

  7. Reviewers should also check tests and documentation.

  8. Reviewers should be prepared to review again after the contributors reaction to the first review.