Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstantDeserializer is not working with offset of zero +00:00 and +00 #18

Closed
kevinjom opened this issue Mar 13, 2017 · 2 comments
Closed
Milestone

Comments

@kevinjom
Copy link
Contributor

kevinjom commented Mar 13, 2017

I am working on a project with Spring boot, and it uses Jackson as the json parse library behind to scene to parse http input message into Objects. And some of our clients will pass a timestamp string like this 2017-03-13T11:11:11.000+00:00, and I found that didn't work with current implementation of InstantDeserializer.java.

I am thinking if we can replace a zone offset of zero that is +0000 with Z, we probably should also replace +00:00 and +00 as well, because as I found in this Wiki page, they are also valid zero offsets.

I didn't find a CONTRIBUTION guide so I've made a quick change here, I am not sure if you guys are happy with that. If so, I'd like to make a request to fix it.

@kevinjom
Copy link
Contributor Author

Well, I've created a PR #19 here.

@cowtowncoder cowtowncoder added this to the 2.9.0.pr2 milestone Mar 15, 2017
cowtowncoder added a commit that referenced this issue Mar 15, 2017
@cowtowncoder
Copy link
Member

Excellent, merged, will be in 2.9.0(-pr2)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants