Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces may have non-abstract methods (since java8) #52

Closed
wants to merge 1 commit into from

Conversation

hrhino
Copy link

@hrhino hrhino commented Jul 18, 2018

and those methods may override abstract methods in superinterfaces, so don't skip the hasConcreteOverride method just because we're materializing an interface.

and those methods may override abstract methods in superinterfaces,
so don't skip the `hasConcreteOverride` method just because we're
materializing an interface.
@hrhino
Copy link
Author

hrhino commented Jul 18, 2018

the afterburner tests appear to be failing; I think the Mr Bean tests should all be good

@cowtowncoder
Copy link
Member

@hrhino Thank you for contributing this -- somehow I missed it, but hope look into this now and get it merged in for 2.9.7.

@cowtowncoder
Copy link
Member

@hrhino Ok, looks good. One last (?) thing: unless I have asked for and received CLA earlier, I'd need that from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print, fill & sign, scan, email to info at fasterxml dot com. Only needs to be done once and works for all contributions to all Jackson projects.
If that can be done, I'll merge this fix in 2.9 branch and we are good to go.

Thank you again for the contribution!

@cowtowncoder
Copy link
Member

Manually merged; changed test slightly as it's not a case of having a getter but rather just regular method of interface.

cowtowncoder added a commit that referenced this pull request Apr 5, 2019
stevenschlansker pushed a commit to stevenschlansker/jackson-modules-base that referenced this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants