Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stack trace from Blackbirds warnings wrt missing MethodHandles.lookup() (on Java 8) #187

Closed
cowtowncoder opened this issue Nov 1, 2022 · 3 comments
Labels
blackbird Issue related to Blackbird module
Milestone

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Nov 1, 2022

(request by @darxriggs)

"It's a bit disturbing to see a stack trace in normal operation when Blackbird is used with Java 8 for example.

Do you think removing the exception with its stacktrace from the log message is an option?"


This seems reasonable to me, will check with @stevenschlansker .

Code in question is in ReflectionHack line 44 or so; would just log but without stack trace.

@cowtowncoder cowtowncoder added the blackbird Issue related to Blackbird module label Nov 1, 2022
@stevenschlansker
Copy link
Contributor

The reason the exception was logged in the first place was to help diagnose problems with oddball JVMs - "I ran this on IBM JDK and it didn't work right!"
We could remove it, or alternately reduce the level to TRACE level so it is available but hidden by default.

One word of caution, if you do run Java 8, then Blackbird is probably not performing very well. It is best to update your Java version to get actually good performance with Blackbird :)

@cowtowncoder
Copy link
Member Author

Yeah makes sense that exception would be useful for tracking down issues. I think combination makes sense: log a general notification as WARNING but then more detailed info at trace (FINE).

@cowtowncoder cowtowncoder added this to the 2.14.0 milestone Nov 2, 2022
@cowtowncoder
Copy link
Member Author

Thank you @stevenschlansker I think the idea of hiding (but not removing) exception stack trace makes sense. Will get in 2.14.0 release as one of very last things. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blackbird Issue related to Blackbird module
Projects
None yet
Development

No branches or pull requests

2 participants