Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jakarta-variant of "JAXB" annotations: jackson-module-jakarta-xmlbind-annotations #130

Closed
cowtowncoder opened this issue Mar 16, 2021 · 2 comments
Milestone

Comments

@cowtowncoder
Copy link
Member

So, with Javax->Jakarta developments wherein JAXB api is now forked hard, we have an attempted workaround of using classifier "jakarta", publishing 2 jar variants.
But this seems to have issues at least wrt OSGi; so maybe we better bite the bullet, create 2nd module with copied code but covering Jakarta variant of XML binding API.

Also see my question on what to call "new" JAXB:

jakartaee/jaxb-api#179

This would be for Jackson 2.13. Trade-off as I see it:

  • CON: More code to maintain for now -- possibly not for 3.0 (if we only migrate new variant)
  • PRO: Known to work: 2 different artifacts, simple dependencies, no post-processing
@cowtowncoder
Copy link
Member Author

Added new variant:

  • Sub-folder: jakarta-xmlbind
  • Maven coordinates:
    • Artifactjackson-module-jakarta-xmlbind-annotations (group id com.fasterxml.jackson.module)
  • Java package: com.fasterxml.jackson.module.jakarta.xmlbind
  • Module id: com.fasterxml.jackson.module.jakarta.xmlbind (same as Java package)
  • Module name: JakartaXmlBindAnnotationModule

@cowtowncoder
Copy link
Member Author

cc @GedMarc I think that due to complications with dependencies, this is the route to take. Work so far:

  1. Remove JAXB annotations dependency from XML module (used only for tests, but not required runtime)
  2. Add alternate Jakarta-XMLBind module here (help appreciated wrt metadata) -- mostly to remove now unnecessary imports from module def if necessary

And then I'll need to tackle RS side. I think jaxrs just becomes jakarta-rs from Jackson perspective; although kind of wondering if I should also try to remove JAXB annotation dependency (removed from 3.0, but tempted to drop automatic support from Jakarta/2.13 variant).

@cowtowncoder cowtowncoder changed the title Consider adding Jakarta-variant of "JAXB" annotations -- jackson-module-jakb-annotations ? Add Jakarta-variant of "JAXB" annotations: jackson-module-jakarta-xmlbind-annotations Apr 25, 2021
cowtowncoder added a commit that referenced this issue Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant