Change MKPE.parameter property to transient. #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporary workaround for FasterXML#572
k163377
commented
Mar 21, 2023
| @@ -18,7 +18,9 @@ import kotlin.reflect.KParameter | |||
| ), | |||
| DeprecationLevel.WARNING | |||
| ) | |||
| class MissingKotlinParameterException(val parameter: KParameter, | |||
| // When deserialized by the JDK, the parameter property will be null, ignoring nullability. | |||
| // This is a temporary workaround for #572 and we will eventually remove this class. | |||
There was a problem hiding this comment.
As per the comment, there is a problem that deserialization destroys null safety.
However, considering compatibility and the low importance of deserialization, I think this approach is better.
cowtowncoder
approved these changes
Mar 22, 2023
k163377
added a commit
to k163377/jackson-module-kotlin
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround for #572