Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonNode, ArrayNode and ObjectNode extensions #489

Merged
merged 3 commits into from Aug 30, 2021

Conversation

sokomishalov
Copy link
Contributor

@sokomishalov sokomishalov commented Aug 26, 2021

Implements #492

@cowtowncoder
Copy link
Member

This seems like potentially useful (if I understand the intent) additions.
I think it'd be useful to have couple of more things included:

  1. Issue with actual description of why and what (could just add Description to PR too)
  2. Basic unit test coverage
  3. A small bit of documentation on either README.md of Kotlin module, or under Wiki -- explaining use of these additional operations.

@sokomishalov
Copy link
Contributor Author

@cowtowncoder sure, done

@dinomite dinomite self-assigned this Aug 27, 2021
@cowtowncoder
Copy link
Member

Thanks! I'll let module owners review this otherwise. This may still make it in 2.13.0 if they approve (I pushed last rc, 2.13.0-rc2 last night, but 2.13.0 won't be out until next weekend or weekend after that).

@dinomite dinomite linked an issue Aug 29, 2021 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@dinomite
Copy link
Member

@sokomishalov Have you signed the CLA? If not, would you fill it out and email a scan/photo of the result to info at fasterxml dot com?

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

@sokomishalov
Copy link
Contributor Author

@dinomite I've signed and sent the document to the mailbox, also made changes due to your suggestions, please have a look again

@cowtowncoder
Copy link
Member

CLA received just like @sokomishalov said.

@cowtowncoder
Copy link
Member

I wonder if it'd make sense to add one more cla-related labels (cla-needed, cla-available ... or something)?
One challenge may be that only admins can add/remove labels.

@dinomite dinomite merged commit 752b0cb into FasterXML:2.13 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide operator overloadings for JsonNode inheritors
3 participants