Optimize KotlinNamesAnnotationIntrospector.findImplicitPropertyName method.
#456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
force-pushed
the
optimize_findImplicitPropertyName
branch
from
f4a93b6
to
5c675f1
Compare
|
@dinomite |
dinomite
approved these changes
Oct 15, 2021
|
GitHub merged this but thinks it didn't ¯_(ツ)_/¯ |
dinomite
added a commit
that referenced
this pull request
Oct 15, 2021
Optimize `KotlinNamesAnnotationIntrospector.findImplicitPropertyName` method.
|
@dinomite It seems that the wrong branch has been created, so please delete it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an excerpt of the optimization part of
findImplicitPropertyNamfrom #451.The following explanation is taken from #451 (comment) .
The
isInlineClasschecks if there is a method with a name containing-in the class that defines theMethod.On the other hand, the
findImplicitPropertyNamechecks if the name of thegettercontains-.This means that patterns that require an implicit name will always have
isInlineClassset totrue, making this check seem unnecessary.