Fixed mapping failure when private companion object is named

[k163377]

Currently, when retrieving a companion object from a field, the name is used for comparison.

jackson-module-kotlin/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinValueInstantiator.kt

Line 74 in 244b27f

val companionField = possibleCompanion.java.enclosingClass.fields.firstOrNull { it.name == "Companion" }

On the other hand, you can name the companion object as follows.
In this case, the field name in the compilation result will not be Companion.

companion object Named {

}

This causes the mapping to fail.

We fixed this in PR.

Question

I would like to submit a CLA, but is it enough to fill in Your name and Email?
Also, where should I submit it?

I'm not familiar with English or submitting the CLA, so I don't know what to do.
If you could tell me how to do it, I would be very grateful.

Thank you.

[cowtowncoder]

You can find CLA document here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the process is usually so that you will print the document, fill in name and other fields, sign; then scan it (or take a photo with phone), and finally send that to info at fasterxml dot com address.
This needs to be done just once before the first contribution gets merged.

[cowtowncoder]

Also: while this looks like a relatively simple fix, it might be safer against 2.13 branch, just in case.

@dinomite WDYT?

[k163377]

@cowtowncoder I think I probably could have done it, so please check.

[k163377]

@dinomite @cowtowncoder
Fixed the base to 2.13 according to the comment.
#408 (comment)

[dinomite]

Looks good, I'll get this merged shortly.

[cowtowncoder]

quick note: thank you everyone for handling this quickly; I filed the CLA in the meantime and will update release notes (https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.13/ and release-notes/VERSION-2.x)

[dinomite]

@cowtowncoder Thanks for getting the notes!