Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jakarta EE 9: split into 2 modules, old jackson-module-jsonSchema and new jackson-module-jsonSchema-jakarta #151

Merged
merged 2 commits into from Feb 8, 2023

Conversation

reda-alaoui
Copy link
Contributor

Fixes #150

@pjfanning
Copy link
Member

could you move the src to the javax/src and jakarta/src?

Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested

@reda-alaoui
Copy link
Contributor Author

could you move the src to the javax/src and jakarta/src?

Isn't that what the PR already reflect?

@pjfanning
Copy link
Member

could you move the src to the javax/src and jakarta/src?

Isn't that what the PR already reflect?

Apologies, I misinterpreted the diff - this is ok as is. I'm still -1 on the package name but otherwise this largely seems fine.

Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - seems ok to me - I'll leave it to @cowtowncoder to decide on whether to merge

@cowtowncoder
Copy link
Member

Ok phew. I am bit ambivalent here only because I was hoping this module just... disappeared :)

But since it is still being used I think this makes sense: thank you @reda-alaoui for doing this work!

Let me think this over for a bit; I will probably accept this and merge, but I want to make sure I won't have any regrets.

@cowtowncoder
Copy link
Member

Thank you again, @reda-alaoui -- will merge this now.

@cowtowncoder cowtowncoder merged commit fb388b2 into FasterXML:master Feb 8, 2023
@cowtowncoder cowtowncoder modified the milestones: 2.15., 2.15.0 Feb 8, 2023
@reda-alaoui reda-alaoui deleted the jakarta branch February 8, 2023 07:37
@jorgerod
Copy link

Thank you very much for your contribution @reda-alaoui! I was using this dependency and needed the support to jakarta.

@cowtowncoder @pjfanning Is there a release date for 2.15.0?

Thank you very much

@cowtowncoder
Copy link
Member

@jorgerod 2.15.0-rc1 was released a week ago, and I was hoping to release 2.15.0-rc2 today. With that, hope is that 2.15.0 final would get released within 2-4 weeks.

@cowtowncoder cowtowncoder changed the title Support jakarta EE 9 Support jakarta EE 9: split into 2 modules, old jackson-module-jsonSchema and new jackson-module-jsonSchema-jakarta May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support jakarta EE 9
4 participants