Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module-info.java of jr-stree refers to module com.fasterxml.jackson.jr.ob.api, which is not defined #98

Closed
qurben opened this issue Sep 5, 2022 · 3 comments
Milestone

Comments

@qurben
Copy link

qurben commented Sep 5, 2022

module-info.java in jr-stree requires com.fasterxml.jackson.jr.ob.api, but this module does not exist, this package is exported by com.fasterxml.jackson.jr.ob, but that doesn't mean it is required to explicitly require this package.

@cowtowncoder
Copy link
Member

I don't quite understand the problem here: that package is exposed by jr-objects and as name suggests contains API types for that module. Stree module needs it. What is not defined? What should be changed?

@qurben
Copy link
Author

qurben commented Sep 6, 2022

jr-stree should only require the com.fasterxml.jackson.jr.ob module, this implies access to the api package (because this module exports the api package).

require is for requiring modules, not packages.

The error I'm getting is

'java.lang.module.FindException: Module com.fasterxml.jackson.jr.ob.api not found, required by com.fasterxml.jackson.jr.stree'.

@cowtowncoder
Copy link
Member

cowtowncoder commented Sep 6, 2022

Ahh. Ok yes. I.... have not used module system for anything myself and forgot the asymmetry (exporting package, requiring modules). Thank you for the explanation, you are obviously correct here.

@cowtowncoder cowtowncoder changed the title module-info.java refers to com.fasterxml.jackson.jr.ob.api, which is not defined. module-info.java of jr-stree refers to module com.fasterxml.jackson.jr.ob.api, which is not defined Sep 6, 2022
cowtowncoder added a commit that referenced this issue Sep 11, 2022
Remove bogus module dependencies to fix #98
@cowtowncoder cowtowncoder added this to the 2.13.5 milestone Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants