Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jr-stree dependency to jr-objects optional #88

Closed
yawkat opened this issue Jul 29, 2021 · 4 comments
Closed

Make jr-stree dependency to jr-objects optional #88

yawkat opened this issue Jul 29, 2021 · 4 comments
Milestone

Comments

@yawkat
Copy link
Member

yawkat commented Jul 29, 2021

stree doesn't really have a reason to depend on jr-objects. The only dependency is in JrSimpleTreeExtension.

Because there are already no other code dependencies in the jr-stree module, users can already add an exclusion for the jr-objects artifact and jr-stree will still work fine. However, this approach doesn't guarantee that it'll keep working in the future.

Making the dependency to jr-objects optional in the pom.xml would be better. It is technically a breaking change for users that only depend on jr-stree but still use jr-objects, but this is not an issue in my opinion. It's still not something that should appear in a patch release, but it would be fine for 2.13 (unless it's too late for that now?).

Thoughts?

@cowtowncoder
Copy link
Member

Hmmh. Interesting. Did not quite realize that there is no real dependency.

So, +1 for removing dependency from 2.13 -- I think that while it might cause an issue for someone, it seems like the right thing to do conceptually.

If you have time to do PR against 2.13, including a note on README(s?), that'd be good. I can then update 2.13 release notes with the info.

@cowtowncoder
Copy link
Member

Oh nm wrt PR, saw your other note. I'll work on this on my own, seems simple enough.

@yawkat
Copy link
Member Author

yawkat commented Aug 13, 2021

Thanks! Just making the dep optional should do it.

@cowtowncoder
Copy link
Member

Ah. Somehow I missed what you mentioned, class JrSimpleTreeExtension when grepping (and not reading the description well).
That was the reason for adding dependency. But marking it as optional does seem like a reasonable idea.
I guess provided could also work but maybe optional is better way.

@cowtowncoder cowtowncoder changed the title jr-stree without jr-objects Make jr-stree dependency to jr-objects optional Aug 14, 2021
@cowtowncoder cowtowncoder added this to the 2.13.0 milestone Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants