You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
stree doesn't really have a reason to depend on jr-objects. The only dependency is in JrSimpleTreeExtension.
Because there are already no other code dependencies in the jr-stree module, users can already add an exclusion for the jr-objects artifact and jr-stree will still work fine. However, this approach doesn't guarantee that it'll keep working in the future.
Making the dependency to jr-objects optional in the pom.xml would be better. It is technically a breaking change for users that only depend on jr-stree but still use jr-objects, but this is not an issue in my opinion. It's still not something that should appear in a patch release, but it would be fine for 2.13 (unless it's too late for that now?).
Thoughts?
The text was updated successfully, but these errors were encountered:
Ah. Somehow I missed what you mentioned, class JrSimpleTreeExtension when grepping (and not reading the description well).
That was the reason for adding dependency. But marking it as optional does seem like a reasonable idea.
I guess provided could also work but maybe optional is better way.
cowtowncoder
changed the title
jr-stree without jr-objects
Make jr-stree dependency to jr-objects optional
Aug 14, 2021
stree doesn't really have a reason to depend on jr-objects. The only dependency is in
JrSimpleTreeExtension
.Because there are already no other code dependencies in the jr-stree module, users can already add an exclusion for the jr-objects artifact and jr-stree will still work fine. However, this approach doesn't guarantee that it'll keep working in the future.
Making the dependency to jr-objects optional in the pom.xml would be better. It is technically a breaking change for users that only depend on jr-stree but still use jr-objects, but this is not an issue in my opinion. It's still not something that should appear in a patch release, but it would be fine for 2.13 (unless it's too late for that now?).
Thoughts?
The text was updated successfully, but these errors were encountered: