Support @JsonProperty annotation on enum values
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me add a +1 to this. I just had to rewrite some code because this didn't exist. |
|
Excellent improvement, will merge. |
cowtowncoder
changed the title
@JsonProperty annotation on enum values
|
Quick note: added a brief on README of |
| { | ||
| public class AnnotationBasedValueRWModifier extends ReaderWriterModifier { | ||
| // Matches SER_ENUM code in ValueLocatorBase | ||
| protected static final int SER_ENUM = 23; |
There was a problem hiding this comment.
lol. As a sidenote, it did change in 3.0 to 24 :)
(will change ValueLocatorBase to public to avoid this case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
@JsonPropertyannotation on enum values so that enums can be serialized and deserialized with custom names.Added new tests to verify this functionality which are passing. All existing tests are passing.