Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsrValue should implement equals() #81

Closed
MikeDombo opened this issue May 11, 2021 · 2 comments
Closed

JsrValue should implement equals() #81

MikeDombo opened this issue May 11, 2021 · 2 comments
Milestone
2.13.0

Comments

@MikeDombo
Copy link
Contributor

JsrValue class should implement equals properly for easier validation, especially during testing.
@cowtowncoder
Copy link
Member

Sounds like a good idea, yes.

@cowtowncoder cowtowncoder changed the title JsrValue should implement equals JsrValue should implement equals() May 14, 2021
@cowtowncoder cowtowncoder added this to the 2.13.0 milestone May 14, 2021
cowtowncoder added a commit that referenced this issue May 14, 2021
@cowtowncoder
Add trivial unit tests for #81
0acce6b
@MikeDombo
Copy link
Contributor Author

Resolved by #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@cowtowncoder @MikeDombo