Fix for failing Guava Optional test
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am guessing the same would need to be done for |
JooHyukKim
reviewed
Dec 16, 2023
guava/src/main/java/com/fasterxml/jackson/datatype/guava/ser/GuavaBeanSerializerModifier.java
Outdated
Show resolved
Hide resolved
…uavaBeanSerializerModifier.java Co-authored-by: Kim, Joo Hyuk <beanskobe@gmail.com>
cowtowncoder
approved these changes
Dec 18, 2023
| @@ -24,7 +28,13 @@ public List<BeanPropertyWriter> changeProperties(SerializationConfig config, | |||
| { | |||
| for (int i = 0; i < beanProperties.size(); ++i) { | |||
| final BeanPropertyWriter writer = beanProperties.get(i); | |||
| if (Optional.class.isAssignableFrom(writer.getType().getRawClass())) { | |||
| // [databind#0000] Since 2.17 : problem to solve + reason for matching Unwrapping....Writer | |||
| if (writer instanceof UnwrappingBeanPropertyWriter) { | |||
There was a problem hiding this comment.
Oh actually... shouldn't this only apply to Optional type properties? I don't think we want to change standard UnwrappingBeanPropertyWriter for other types, otherwise it'd change behavior
So, I think this if statement should be inside if (Optional.class.isAssignableFrom(...)), not at same level.
There was a problem hiding this comment.
Ah, excellent catch. I believe my initial PR was accurate. The error occurred when I attempted to rewrite it from memory the second time around. The issue has now been resolved. Thanks :)
cowtowncoder
approved these changes
Dec 18, 2023
cowtowncoder
changed the title
Optional test
cowtowncoder
added a commit
that referenced
this pull request
Dec 18, 2023
|
Merged for inclusion in 2.17.0. Thank you @mukham12 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.