Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCollections module info (module-info.class) incorrect #122

Closed
bowbahdoe opened this issue Oct 14, 2023 · 4 comments
Closed

PCollections module info (module-info.class) incorrect #122

bowbahdoe opened this issue Oct 14, 2023 · 4 comments

Comments

@bowbahdoe
Copy link

        <dependency>
            <groupId>com.fasterxml.jackson.datatype</groupId>
            <artifactId>jackson-datatype-pcollections</artifactId>
            <version>2.15.3</version>
        </dependency>

        <dependency>
            <groupId>org.pcollections</groupId>
            <artifactId>pcollections</artifactId>
            <version>4.0.1</version>
        </dependency>
Error occurred during initialization of boot layer
java.lang.module.FindException: Module pcollections not found, required by jackson.datatype.pcollections

Their module name is now org.pcollections https://github.com/hrldcpr/pcollections/blob/master/src/main/java/module-info.java

@yawkat yawkat added the good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project label Oct 16, 2023
@cowtowncoder
Copy link
Member

Thank you for reporting this @bowbahdoe. Sounds like something to fix in config file for Moditect.

@cowtowncoder cowtowncoder changed the title PCollections support broken PCollections module info (module-info.class) incorrect Oct 16, 2023
@cowtowncoder cowtowncoder removed the good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project label Oct 17, 2023
@bowbahdoe
Copy link
Author

@cowtowncoder You fixed that without bumping the minimum version of pcollections. This was an error encountered with 4.x.y, I don't know if it was an issue with 2.x.y

@cowtowncoder
Copy link
Member

cowtowncoder commented Oct 18, 2023

Ugh. Was too hasty, assumed it was a problem you had encountered and... crap.
But the problem description was somewhat misleading. Even then, I should have paid attention to the version number.

Thank you for pointing this out; will change.

@cowtowncoder
Copy link
Member

Updated for 2.16.0. For 2.15.x bit unclear on what to do since as far as I can see, module-info is only added in PCollections 4.0.1 -- so there is no module name for prior versions. But also not sure how safe it'd be to upgrade PCollections dependency from 2.x to 4.x in a patch (of 2.15).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants