Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

New configuration for Guava Range default bound type. #79

Merged
merged 1 commit into from Aug 19, 2015

Conversation

jorool
Copy link
Contributor

@jorool jorool commented Aug 12, 2015

Now it's possible do set a default bound type for Guava Range objects.
The intent of this is to get the JSON deserialized without informing the bound types every time even when wanted to use the same one for all objects.
The configured default bound type is passed to the deserializer by constructor method.
If the JSON object has no bound type and there's no default configured, we still get the exception.
I added some test cases with and without default bound type configured.

@jorool
Copy link
Contributor Author

jorool commented Aug 12, 2015

@cowtowncoder What about that failing test?

TestVersions.testMapperVersions:16->assertVersion:35 expected:<2.6.2-SNAPSHOT> but was:<2.6.1>

@cowtowncoder
Copy link
Member

@jorool I do not see any test failures. Message would indicate that you haven't done a clean Maven build perhaps? ("mvn clean compile")

@jorool
Copy link
Contributor Author

jorool commented Aug 12, 2015

@cowtowncoder I'm talking about Travis CI. The "check" failed. 😄

@cowtowncoder
Copy link
Member

Hmmh. That's odd, but reliability of Travis setup has been rather poor. :-(

@jorool
Copy link
Contributor Author

jorool commented Aug 12, 2015

@cowtowncoder So... what should we do? Will you merge it?

@cowtowncoder
Copy link
Member

Yes, I think that's good enough.

One thing first however: unless I have asked about it already... we need filled in Contributor License Agreement (https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf) before the first merger contribution. This is only needed once, and after that we can accept any number of contributions for Jackson projects.

The easiest way is usually to print CLA form, fill & sign, scan and email to info at fasterxml dot com.
Once we receive it I can go ahead and merge this. It will be a good addition.

Thank you in advance.

@jorool
Copy link
Contributor Author

jorool commented Aug 18, 2015

@cowtowncoder Done. Email sent.

Let me know if you need something else.

Thanks.

cowtowncoder added a commit that referenced this pull request Aug 19, 2015
New configuration for Guava Range default bound type.
@cowtowncoder cowtowncoder merged commit d00da16 into FasterXML:master Aug 19, 2015
@@ -3,7 +3,11 @@
import com.fasterxml.jackson.core.Version;

import com.fasterxml.jackson.databind.*;
import com.fasterxml.jackson.databind.cfg.PackageVersion;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this caused the bug -- PackageVersion must not come from version of another module, like jackson-databind.
It is generated by Maven build. I removed this which fixes the unit test fail.

cowtowncoder added a commit that referenced this pull request Aug 19, 2015
@cowtowncoder cowtowncoder added this to the 2.7.0 milestone Aug 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants