Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fast floating-point parsing, generation support #314

Merged
merged 9 commits into from Jun 26, 2022
Merged

Add fast floating-point parsing, generation support #314

merged 9 commits into from Jun 26, 2022

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Jun 25, 2022 •
edited

Relates to #312

@pjfanning pjfanning marked this pull request as draft June 25, 2022 14:46
@cowtowncoder
Copy link
Member

Sounds good, just LMK when it's ready!

@pjfanning pjfanning marked this pull request as ready for review June 26, 2022 10:21
@pjfanning pjfanning changed the title WIP: Fast parser support Fast parser support Jun 26, 2022
@cowtowncoder
Copy link
Member

Looks good: just one fix I'd like made wrt passing of setting.

@pjfanning
Copy link
Member Author

@cowtowncoder could you re-review? I think I've addressed all the issues you highlighted.

@cowtowncoder
Copy link
Member

One potential follow-up thing: I do not recall the need for local NumberInput / NumberOutput, could perhaps remove them. In some cases duplication was, I think, in trying not to have to rely on latest jackson-core version (to add slightly bigger range of compatible versions). But that's not a very good reason given that there was no testing of true compatibility anyway.

For Jackson 3.0 could also consider renaming these in jackson-core as JsonNumberInput / JsonNumberOutput or something... not sure what'd be the best way to indicate they are focused on JSON-specific number representations which are stricter than JDK or YAML (and conceivably CSV).

@cowtowncoder cowtowncoder merged commit 61b4f79 into FasterXML:2.14 Jun 26, 2022
@pjfanning pjfanning deleted the fast-parser-support branch June 26, 2022 19:18
@cowtowncoder cowtowncoder changed the title Fast parser support Add fast floating-point parsing, generation support Jun 26, 2022
cowtowncoder added a commit that referenced this pull request Jun 26, 2022
@cowtowncoder
Add a mention of #314 in release notes; minor cleanup
7edb80a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pjfanning @cowtowncoder