Typed object throws "Missing type id" when annotated with @JsonIdentityInfo

[almson]

Tested with Jackson 2.12.0-rc2-SNAPSHOT

import com.fasterxml.jackson.annotation.JsonIdentityInfo;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonSubTypes.Type;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
import com.fasterxml.jackson.annotation.JsonTypeInfo.Id;
import com.fasterxml.jackson.annotation.ObjectIdGenerators;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import java.util.List;
import org.junit.Test;

public class JacksonYamlTest {
    
    static class Container {
        @JsonProperty
        List<Base> list;
    }
    
    @JsonTypeInfo(use = Id.NAME)
    @JsonSubTypes({@Type(name="Derived", value=Derived.class)})
    @JsonIdentityInfo(generator = ObjectIdGenerators.StringIdGenerator.class)
    static class Base {
        
    }
    
    static class Derived extends Base {
        @JsonProperty
        String a;
    }
    
    @Test
    public void typedTestYaml() throws Exception {
        
        String yaml = "list:\n" +
                      "    - !Derived\n" +
                      "        a: foo";
        
        ObjectMapper mapper = new ObjectMapper (new YAMLFactory());
        Container container = mapper.readValue (yaml, Container.class);
        
        System.out.println (((Derived)container.list.get(0)).a);
    }
    
    @Test
    public void typedTestJson() throws Exception {
        
        String json = "{\"list\":[{\"@type\":\"Derived\",\"a\":\"foo\"}]}";
        
        ObjectMapper mapper = new ObjectMapper();
        Container container = mapper.readValue (json, Container.class);
        
        System.out.println (((Derived)container.list.get(0)).a);
    }
}

typedTestYaml throws:

com.fasterxml.jackson.databind.exc.InvalidTypeIdException: 
Missing type id when trying to resolve subtype of [simple type, class JacksonYamlTest$Base]: missing type id property '@type' (for POJO property 'list')
 at [Source: (StringReader); line: 3, column: 15] (through reference chain: JacksonYamlTest$Container["list"]->java.util.ArrayList[0])
	at com.fasterxml.jackson.databind.exc.InvalidTypeIdException.from(InvalidTypeIdException.java:43)
	at com.fasterxml.jackson.databind.DeserializationContext.missingTypeIdException(DeserializationContext.java:1945)
	at com.fasterxml.jackson.databind.DeserializationContext.handleMissingTypeId(DeserializationContext.java:1458)
	at com.fasterxml.jackson.databind.jsontype.impl.TypeDeserializerBase._handleMissingTypeId(TypeDeserializerBase.java:307)
	at com.fasterxml.jackson.databind.jsontype.impl.AsPropertyTypeDeserializer._deserializeTypedUsingDefaultImpl(AsPropertyTypeDeserializer.java:174)
	at com.fasterxml.jackson.databind.jsontype.impl.AsPropertyTypeDeserializer.deserializeTypedFromObject(AsPropertyTypeDeserializer.java:113)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.deserializeWithType(BeanDeserializerBase.java:1277)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeWithObjectId(CollectionDeserializer.java:443)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeFromArray(CollectionDeserializer.java:334)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:244)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:28)
	at com.fasterxml.jackson.databind.deser.impl.FieldProperty.deserializeAndSet(FieldProperty.java:138)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:324)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:187)
	at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:322)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4591)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3546)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3514)
	at JacksonYamlTest.typedTestYaml(JacksonYamlTest.java:54)com.fasterxml.jackson.databind.exc.InvalidTypeIdException: 
Missing type id when trying to resolve subtype of [simple type, class JacksonYamlTest$Base]: missing type id property '@type' (for POJO property 'list')
 at [Source: (StringReader); line: 3, column: 15] (through reference chain: JacksonYamlTest$Container["list"]->java.util.ArrayList[0])
	at com.fasterxml.jackson.databind.exc.InvalidTypeIdException.from(InvalidTypeIdException.java:43)
	at com.fasterxml.jackson.databind.DeserializationContext.missingTypeIdException(DeserializationContext.java:1945)
	at com.fasterxml.jackson.databind.DeserializationContext.handleMissingTypeId(DeserializationContext.java:1458)
	at com.fasterxml.jackson.databind.jsontype.impl.TypeDeserializerBase._handleMissingTypeId(TypeDeserializerBase.java:307)
	at com.fasterxml.jackson.databind.jsontype.impl.AsPropertyTypeDeserializer._deserializeTypedUsingDefaultImpl(AsPropertyTypeDeserializer.java:174)
	at com.fasterxml.jackson.databind.jsontype.impl.AsPropertyTypeDeserializer.deserializeTypedFromObject(AsPropertyTypeDeserializer.java:113)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.deserializeWithType(BeanDeserializerBase.java:1277)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeWithObjectId(CollectionDeserializer.java:443)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeFromArray(CollectionDeserializer.java:334)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:244)
	at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:28)
	at com.fasterxml.jackson.databind.deser.impl.FieldProperty.deserializeAndSet(FieldProperty.java:138)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:324)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:187)
	at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:322)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4591)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3546)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3514)
	at JacksonYamlTest.typedTestYaml(JacksonYamlTest.java:54)

[cowtowncoder]

Note: possibl related to #25.

[cowtowncoder]

Added failing test based on example.

[cowtowncoder]

Not sure what to do but noting that this is probably related to buffering of Type and/or Object Ids: TokenBuffer does hold on to them, but looks like type id is associated with MappingStart event, not name part that follows. I suspect this is similar to how Object Id handling is delayed, and should be handled same way... but not sure how to, yet.

[cowtowncoder]

On further inspection, no buffering involved in this particular case. But type-id is off between cases: without @JsonIdentityInfo, type id asked at START_OBJECT and is found; with it asked on following FIELD_NAME and no longer available.

[benjaminwiegand]

What was the solution to this?
@cowtowncoder
I tried to add @JsonIdentiyInfo with ids but I got the same error message.

[yawkat]

@benjaminwiegand it was fixed in this commit: 2a07652

Do you still have the error in the latest jackson version?

[benjaminwiegand]

Yes I do (jackson 2.12.1). See below for code. What am I missing? @yawkat @cowtowncoder

[benjaminwiegand]

I have a classes:

public class TownHouse(){
   ArrayList<Garage> garages;
  ... other stuff here ...
} 
public Class Garage() {
 @JsonProperty
 ArrayList<Bike> bikes;
 @JsonProperty
 String location;
}

@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.AsPROPERTY, property = "type")
@JsonSubTypes({@JsonSubTypes.Type(value = TrickBike.class, name ="TrickBike),
                            @JsonSubTypes.Type(value = JumpBike.class, name ="JumpBike),
                            @JsonSubTypes.Type(value = MountainBike.class, name ="MountainBike),
                            @JsonSubTypes.Type(value = Bike.class, name ="Bike),
})
@JsonTypeName("Bike")
public class Bike{
    int numWheels;
}
@JsonTypeName("TrickBike")
public class TrickBike extends Bike{
     ... other stuff here...
}
@JsonTypeName("JumpBike")
public class JumpBike extends Bike{
         ... other stuff here...

}
@JsonTypeName("MountainBike")
public class MountainBike extends Bike{
     ... other stuff here...

}

And I'm getting, InvalidTypeException: Missing type id when trying to resolve subtype of [simple type, class Bike]: missing type id property 'type' for pojo property bikes when I:

Townhouse th = ....
<add some garages> 
<add some bikes> 
ObjectMapper mapper = new ObjectMapper();
mapper.writeValueAsString(th);

I tried adding @JsonIdentityInfo(generator = ObjectIdGenerators.IntSequenceGenerator.class, property = "@id") but that didn't do anything.

I believe I'm missing some annotation somewhere but not sure where.

[benjaminwiegand]

I fixed it.

[yawkat]

your code does not use yaml though? this was specifically a yaml issue

[githubshivi]

@benjaminwiegand how did you fixed that issue i'm also facing the same issue

[Hassaballah101]

@benjaminwiegand useless comment when u don't say the solution :)

[cowtowncoder]

Original issue was fixed so things should work: perhaps it was a matter of upgrading Jackson YAML module version used.

If you still have problems, please file new issue -- we usually do not re-open old issues since that complicates release note handling (and often follow-up issues are different from original anyway).

You may refer to this issue as background info but the new issue should have reproduction and not assume it is the same root problem; even if the failure message looks the same does not necessarily mean identical issue.
Possibly related (hence ref to this issue can be useful).