Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote 'y'/'Y'/'n'/'N' as names too (to avoid problems with Boolean keys) #226

Closed
cowtowncoder opened this issue Sep 18, 2020 · 0 comments
Closed
Labels
yaml Issue related to YAML format backend
Milestone

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Sep 18, 2020

(note: replacement of #225 targeting 2.12 branch)

Looks like #68 left out single-letter boolean values ("Y"/"y"/"N"/"n") wrt quoting of names, presumable for aesthetic reasons.
It seems better to quote these, however, since they are already quoted when output as values (see MUST_QUOTE_VALUES in YAMLGenerator).
Change is planned for 2.12.0; we can still revisit this after 2.12.0-rc1 if there are actual problems introduced (and if so possibly add Yet Another YAMLGenerator.Feature if need be).

@cowtowncoder cowtowncoder added 2.12 yaml Issue related to YAML format backend labels Sep 18, 2020
@cowtowncoder cowtowncoder changed the title Quote 'y'/'Y'/'n'/'N' boolean values, too Quote 'y'/'Y'/'n'/'N' as names too (to avoid problems with Boolean keys) Sep 18, 2020
@cowtowncoder cowtowncoder added this to the 2.12.0 milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
yaml Issue related to YAML format backend
Projects
None yet
Development

No branches or pull requests

1 participant