Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new CsvParser.Feature.ALLOW_COMMENTS to replace deprecated JsonParser.Feature.ALLOW_YAML_COMMENTS #108

Closed
cowtowncoder opened this issue Sep 26, 2018 · 0 comments
Closed

Add new CsvParser.Feature.ALLOW_COMMENTS to replace deprecated JsonParser.Feature.ALLOW_YAML_COMMENTS #108

cowtowncoder opened this issue Sep 26, 2018 · 0 comments
Milestone
2.10.0

Comments

@cowtowncoder
Copy link
Member

As of Jackson 2.9 CSV parser allows two methods to enable processing of "hash comments" within cells:

  1. CsvSchema has methods to enable this on per-column basis
  2. If JsonParser.Feature.ALLOW_YAML_COMMENTS is enabled, default is to enable for all columns (unless explicitly disabled via schema)

Jackson 2.10 deprecates this feature (and adds JSON-specific replacement), so we should add a CSV-specific variant.
@cowtowncoder cowtowncoder modified the milestones: 2.10, 2.10.0 Sep 26, 2018
@cowtowncoder cowtowncoder changed the title Add new CsvParser.Feature to replace deprecated JsonParser.Feature.ALLOW_YAML_COMMENTS Add new CsvParser.Feature.ALLOW_COMMENTS to replace deprecated JsonParser.Feature.ALLOW_YAML_COMMENTS Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
1 participant
@cowtowncoder