Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest SnakeYAML version 1.23 and get rid of deprecated methods #101

Merged
merged 1 commit into from Aug 31, 2018
Merged

Use latest SnakeYAML version 1.23 and get rid of deprecated methods #101

merged 1 commit into from Aug 31, 2018

Conversation

asomov
Copy link
Contributor

@asomov asomov commented Aug 28, 2018

Fix #81 (and #82)

@cowtowncoder
Copy link
Member

Ok, based on comments in #81 this makes sense and I can merge this for 2.10 . Merge from 2.10 to master is easy enough too.

Just one question to make sure I understand implications: would the new module work against older snakeYAML versions or not? If we were still shading dependency it would not matter, but unfortunately this is not done (due to complications with OSGi use case, long story).

If there are specific limitations (will work for a range of versions) that may be fine, but we need to document those.

@asomov
Copy link
Contributor Author

asomov commented Aug 29, 2018

The new code will work with 1.23 onwards. Older versions are not supported.
(We will do our best to keep the backwards compatibility)

If this is merged to master than the pull request for master can be cancelled.

@cowtowncoder
Copy link
Member

@asomov I'll try to play a bit with this -- perhaps I misunderstand compatibility issue tho.
Maybe it's that new version would work with old code, so that 2.9 can upgrade to 1.23; and then 2.10 can upgrade to use new config?

If so, that's fine. But 2.9 and 2.10 have bit different requirements.

@cowtowncoder
Copy link
Member

Yes, looks like 1.22 and 1.23 have re-added temporarily missing method, and will "just work" as expected.
I will now merge this for 2.10 to upgrade API usage.

@cowtowncoder cowtowncoder merged commit c7729d8 into FasterXML:2.10 Aug 31, 2018
@asomov
Copy link
Contributor Author

asomov commented Aug 31, 2018

I also might misunderstand the issue. Yes, we have added back the missing methods.

I created 3 pull requests which do the same. Upgrade the SnakeYAML version to 1.23

If the commits from 2.9 go to 2.10 and than further to master than you need to merge only one (for 2.9)

cowtowncoder added a commit that referenced this pull request Aug 31, 2018
@asomov
Copy link
Contributor Author

asomov commented Aug 31, 2018

Should I close the pull request for master ?

(if you merge everything to master from 2.10)

@asomov asomov deleted the snakeyaml-1-23 branch August 31, 2018 20:41
@asomov
Copy link
Contributor Author

asomov commented Aug 31, 2018

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants