Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optimized CBORParser.nextTextValue() implementation #373

Closed
cowtowncoder opened this issue Apr 7, 2023 · 0 comments
Closed

Remove optimized CBORParser.nextTextValue() implementation #373

cowtowncoder opened this issue Apr 7, 2023 · 0 comments
Labels
2.15 cbor

Comments

@cowtowncoder
Copy link
Member

(due to #372 )

Although there are theoretical performance benefits from implementing JsonParser.nextTextValue(), the sheer complexity of implementation for CBOR backend makes it a bad trade-off. So let's just drop it from 2.15.0, to avoid hiding subtle bugs that may cause production issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.15 cbor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder