Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent support for StreamWriteFeature.FLUSH_PASSED_TO_STREAM #155

Closed
carterkozak opened this issue Jan 3, 2019 · 1 comment
Closed

Inconsistent support for StreamWriteFeature.FLUSH_PASSED_TO_STREAM #155

carterkozak opened this issue Jan 3, 2019 · 1 comment
Milestone
2.10.0

Comments

@carterkozak
Copy link
Contributor

Cbor and Smile serializers attempt to flush streams on close when AUTO_CLOSE_TARGET is disabled, even if FLUSH_PASSED_TO_STREAM is also disabled.
carterkozak added a commit to carterkozak/jackson-dataformats-binary that referenced this issue Jan 3, 2019
@carterkozak
fix FasterXML#155: Only flush outputs when FLUSH_PASSED_TO_STREAM is …
05374bb 
…allowed

Previously most serializers would attempt a flush when
AUTO_CLOSE_TARGET was disabled, which is not expected if
FLUSH_PASSED_TO_STREAM is also disabled.

This change results in binary serializers behaving the same as
the json serializer.
@cowtowncoder cowtowncoder added this to the 2.10.0 milestone Jan 15, 2019
@cowtowncoder
Copy link
Member

Thank you for reporting this, showing the place where checks were missing. I had to do bit of massaging and ended up manually merging, to get this in 2.10 -- implementation has changed quite a bit between 2.x and (upcoming) 3.0.

@cowtowncoder cowtowncoder changed the title Inconsistent support for FLUSH_PASSED_TO_STREAM Inconsistent support for StreamWriteFeature.FLUSH_PASSED_TO_STREAM Jan 15, 2019
@carterkozak carterkozak mentioned this issue Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
2 participants
@cowtowncoder @carterkozak