Use @JsonProperty over EnumNamingStrategy for Enum serialization
#4040
Conversation
| if (name == null) { | ||
| name = namingStrategy.convertEnumToExternalName(enumValue.name()); | ||
| } | ||
| textual[i] = config.compileString(name); |
There was a problem hiding this comment.
| textual[i] = config.compileString(name); | |
| if (config.isEnabled(EnumFeature.WRITE_ENUMS_TO_LOWERCASE)) { | |
| name = name.toLowerCase(); | |
| } | |
| textual[i] = config.compileString(name); |
Should WRITE_ENUMS_TO_LOWERCASE apply here? (my opinion is no when naming strategy is used... however @JsonProperty is lowercased in constructFromName)
There was a problem hiding this comment.
Depends on how PropertyNamingStategy version does it.
There was a problem hiding this comment.
I don't think there is a lowercase SerializationFeature for the general case
There was a problem hiding this comment.
Correct: lower-casing is datatype-specific, no SerializationFeature (nor will there ever be).
The main question is interesting one; I can see arguments either way.
I think that since EnumFeature.WRITE_ENUMS_TO_LOWERCASE is slightly more dynamic (Enum naming strategy being defined as annotations in class definition or mix-in), it should have precedence and, when enabled, force lower-casing.
There was a problem hiding this comment.
So I think code as-is does what is my leaning. Great!
There was a problem hiding this comment.
@cowtowncoder the current code doesn't force lower-casing, I think you're looking at the suggested diff
Edit: created a PR for this - if I misunderstood your comment, feel free to close it
There was a problem hiding this comment.
@iProdigy Ok I must have thought suggestion was applied and not looked at actual change. Thank you for following through, I just merged follow-up PR!
cowtowncoder
changed the title
@JsonProperty over EnumNamingStrategy for Enum serialization
|
Thank you again @iProdigy for this and other PRs! 2.16 will have much improved handling thanks to these fixes, as well as earlier work by @JooHyukKim. |
Serialization complement of #4037